Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods for creating 7 and 8 versions of UUID to the UuidFactor… #505

Open
wants to merge 2 commits into
base: 4.x
Choose a base branch
from

Conversation

ilyaplot
Copy link

@ilyaplot ilyaplot commented May 4, 2023

Added methods for creating 7 and 8 versions of UUID to the UuidFactoryInterface

Description

Added methods for creating 7 and 8 versions of UUID to the UuidFactoryInterface

Motivation and context

To work with the factory through the interface, you need methods for generating UUID, which are implemented in the factory.

How has this been tested?

This change does not require further testing. If the description of the methods in the interface is incorrect, tests using the implementation of the interface will fail.

Types of changes

  • New feature (non-breaking change which adds functionality)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@ilyaplot ilyaplot requested a review from ramsey as a code owner May 4, 2023 14:11
@ramsey
Copy link
Owner

ramsey commented May 4, 2023

Thanks! This wasn't an oversight. I didn't add them on purpose because releasing this as part of the 4.x series would be a major BC break (since we're adding to an interface).

This will have to wait until the next major version (5.x).

@ilyaplot
Copy link
Author

ilyaplot commented May 4, 2023

Ok, we will be waiting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants