Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unserialize error with OrderedTimeCodec #494 #496

Merged
merged 3 commits into from Apr 15, 2023

Conversation

Ph0tonic
Copy link
Contributor

Provide a fix to the issue #494

Description

I updated the serialize method to take into account the configured codex.

Motivation and context

Fix issue #494, the serialisation method didn't consider the configured codec.

How has this been tested?

A new test was added.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

PR checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #496 (cd91466) into 4.x (abe81c1) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                4.x     #496      +/-   ##
============================================
+ Coverage     95.57%   95.64%   +0.06%     
  Complexity      584      584              
============================================
  Files            70       70              
  Lines          1561     1561              
============================================
+ Hits           1492     1493       +1     
+ Misses           69       68       -1     
Impacted Files Coverage Δ
src/Uuid.php 98.01% <100.00%> (+0.99%) ⬆️

@ramsey ramsey linked an issue Apr 15, 2023 that may be closed by this pull request
@ramsey
Copy link
Owner

ramsey commented Apr 15, 2023

Thank you!

@ramsey ramsey merged commit 628d3df into ramsey:4.x Apr 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unserialize error with OrderedTimeCodec
2 participants