Add getBindingType method to binary types #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ramsey |
|
Is there a way to add a test to verify that this solves the problem? I've been trying to think through how that would work without requiring a database. |
|
@ramsey In the current implementation it's the database itself (or maybe the pdo pgsql driver) that raises the error. Which means you do need the database to write a failing test. |
|
@ramsey Can we get this merged? I'd like to switch my app to binary uuids. |
|
Merged in and release tagged as 1.4.2. Thanks! |
This was referenced Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed this seems to fix the problem reported in ramsey/uuid#179.