Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual version of this package does not work with the next version of composer/composer.
Running the unit tests will return this output :
Description
The fullyLoaded attribute was explicitly set to false, so I changed it to true in order to get a
Composer\Composer
instance instead of aComposer\PartialComposer
one.You can also refer to this pull request to get more context about this change in composer : composer/composer#10547.
It won't introduce any breaking changes (the fullyLoaded argument already existed in composer:^1.10) and it should be compatible with all the php versions supported by this package.
You can find all the internal changes for composer 2.3 here : composer/composer#10573.
I also updated the
totallyTyped
attribute from the Psalm config since it's deprecated and was raising an error : https://psalm.dev/docs/running_psalm/configuration/#totallytyped. I'm not familiar with Psalm but it should have the same behaviour as before.Motivation and context
We need this change to make this package works with the next version of composer/composer (version 2.3.0-RC2 at the moment).
This package just doesn't work for those who are already using the 2.3.0.
How has this been tested?
I didn't add any new tests as the ones already present cover this change : https://github.com/ramsey/conventional-commits/blob/1.3.0/tests/ConventionalCommits/Configuration/FinderToolTest.php#L185.
I also made some some manual tests locally (php8.0 and php8.1) and it works fine.
Types of changes
PR checklist