Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use of deprecated set-output command #238

Merged
merged 10 commits into from Nov 3, 2022
Merged

Fix use of deprecated set-output command #238

merged 10 commits into from Nov 3, 2022

Commits on Nov 3, 2022

  1. First pass at removing set-output. 

    `set-output` has been deprecated. See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/.
    @desrosj @jrfnl
    desrosj authored and jrfnl committed Nov 3, 2022
    Copy the full SHA
    9ed951e View commit details
    Browse the repository at this point in the history

  2. Revert unintentional lock file change.

    @desrosj @jrfnl
    desrosj authored and jrfnl committed Nov 3, 2022
    Copy the full SHA
    02b4d85 View commit details
    Browse the repository at this point in the history

  3. Change command to composer_command. 

    Bash gets confused with the variable being named `command`.
    @desrosj @jrfnl
    desrosj authored and jrfnl committed Nov 3, 2022
    Copy the full SHA
    36abc21 View commit details
    Browse the repository at this point in the history

  4. Undo composer.lock file changes within test fixtures.

    @desrosj @jrfnl
    desrosj authored and jrfnl committed Nov 3, 2022
    Copy the full SHA
    ac7d89f View commit details
    Browse the repository at this point in the history

  5. Add some inline documentation to tests.

    @desrosj @jrfnl
    desrosj authored and jrfnl committed Nov 3, 2022
    Copy the full SHA
    2254605 View commit details
    Browse the repository at this point in the history

  6. Change missed command instance to composer_command.

    @desrosj @jrfnl
    desrosj authored and jrfnl committed Nov 3, 2022
    Copy the full SHA
    aeb2406 View commit details
    Browse the repository at this point in the history

  7. composer_paths.sh: fix issue flagged by shellcheck

    @jrfnl
    jrfnl committed Nov 3, 2022
    Copy the full SHA
    dddb673 View commit details
    Browse the repository at this point in the history

  8. Tests: fix inline comments 

    ... and make them slightly more descriptive.
    @jrfnl
    jrfnl committed Nov 3, 2022
    Copy the full SHA
    c0537c5 View commit details
    Browse the repository at this point in the history

  9. Tests/composer_paths_09.exp: fix expectation 

    Follow up to 237 which updated the `composer.phar` file, but missed the update needed to the test expectations.
    @jrfnl
    jrfnl committed Nov 3, 2022
    Copy the full SHA
    dc35f03 View commit details
    Browse the repository at this point in the history

  10. Tests: fix test which need a pattern match 

    Note: there may well be a way to not have the regex inline, which would make the code more readable, but I'm not familiar enough with Tcl and to be honest, I'm already darn glad that I managed to get it working ;-)

Refs:
* https://www.tcl.tk/man/tcl8.5/TclCmd/regexp.html
* https://www.tcl.tk/man/tcl8.5/TclCmd/re_syntax.html
    @jrfnl
    jrfnl committed Nov 3, 2022
    Copy the full SHA
    fbe8889 View commit details
    Browse the repository at this point in the history