Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions Errors #59

Merged
merged 1 commit into from May 10, 2023
Merged

Fix GitHub Actions Errors #59

merged 1 commit into from May 10, 2023

Conversation

MRichards99
Copy link
Collaborator

This PR fixes an error with GitHub Actions when installing dependencies for the tests. Having read https://stackoverflow.com/questions/76175361/firebase-authentication-httpresponse-object-has-no-attribute-strict-status, it appears that upgrading Poetry to 1.3.2 fixes the issue, and it does!

However, in making this fix, I found another error which happens when installing constraints with Nox (install_with_constraints()). The error was Constraints cannot have extras (see jazzband/pip-tools#1300). There's a couple of different solutions, but the best for now seems to be to use sed to clean the constraints files so they don't have any of these 'extras'. I've documented an alternative solution (which would reduce the amount of code in noxfile.py) but neither of us use a new enough version of Poetry in our dev environments to benefit from the --only option that is now part of Poetry

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (f8a7288) 71.00% compared to head (a55e221) 71.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #59   +/-   ##
=======================================
  Coverage   71.00%   71.00%           
=======================================
  Files          29       29           
  Lines        1252     1252           
  Branches       92       92           
=======================================
  Hits          889      889           
  Misses        343      343           
  Partials       20       20           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MRichards99 MRichards99 merged commit dff558a into main May 10, 2023
14 checks passed
@MRichards99 MRichards99 deleted the github-actions-fix branch May 10, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants