DSEGOG-319 Expose Header #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## DSEGOG-316-parallel-mode-switch #121 +/- ##
================================================================
Coverage 94.99% 94.99%
================================================================
Files 50 50
Lines 2838 2838
Branches 297 297
================================================================
Hits 2696 2696
Misses 105 105
Partials 37 37 ☔ View full report in Codecov by Sentry. |
- This will fix the Safety CI job that reports this dependency contains a vulnerability
Update `orjson` to latest version
DSEGOG-307 Kill API Instances Cleanly in Echo Ingest Script
Bumps [requests](https://github.com/psf/requests) from 2.31.0 to 2.32.2. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.31.0...v2.32.2) --- updated-dependencies: - dependency-name: requests dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
….32.2 Bump requests from 2.31.0 to 2.32.2
|
Just made this PR ready for review as I've got confirmation that the change worked for the frontend team. I'll merge main into this branch to get the CI fully passing |
patrick-austin
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple PR to expose the
Content-Dispositionheader so the frontend can see the filename of the file for the export endpoint. Creating as a draft PR while its being tested by Kacper