Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-315 MongoDB 5.0 to 7.0 #118

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

MRichards99
Copy link
Collaborator

This is a small PR which helps to move MongoDB 5.0 to 7.0. This changes the GitHub Actions to install MongoDB 7.0 and there's also a guide that allows developers to make this change on their development environments. This change is happening because Database Services are now hosting a database using MongoDB 7.0, so we should move to that version as developers for consistency.

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (6ba3184) to head (9708707).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
- Coverage   94.99%   94.91%   -0.09%     
==========================================
  Files          50       50              
  Lines        2837     2871      +34     
  Branches      297      300       +3     
==========================================
+ Hits         2695     2725      +30     
- Misses        105      108       +3     
- Partials       37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@patrick-austin patrick-austin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will come back to this and test the commands work for me on my dev environment.

It doesn't matter because it's symlinked but if these commands are for a Rocky8 machine it will use dnf rather than yum right? Not a request to change just trying to remind myself which way round it is more than anything...

Copy link
Contributor

@patrick-austin patrick-austin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just a bunch of commands that need sudo to run. Main point is that this won't work without the changes from #120 (I assume).

docs/mongodb.md Outdated Show resolved Hide resolved
docs/mongodb.md Outdated
Comment on lines 20 to 28

# Paste the following into /etc/yum.repos.d/mongodb-org-7.0.repo
# Edit the /8/ to /9/ if you're using Rocky 9
[mongodb-org-7.0]
name=MongoDB Repository
baseurl=https://repo.mongodb.org/yum/redhat/8/mongodb-org/7.0/x86_64/
gpgcheck=1
enabled=1
gpgkey=https://pgp.mongodb.com/server-7.0.asc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't a bash command I think it would be better to make it a separate code block, e.g (formatting isn't great because of the nested backticks but hopefully it makes sense:

Suggested change
# Paste the following into /etc/yum.repos.d/mongodb-org-7.0.repo
# Edit the /8/ to /9/ if you're using Rocky 9
[mongodb-org-7.0]
name=MongoDB Repository
baseurl=https://repo.mongodb.org/yum/redhat/8/mongodb-org/7.0/x86_64/
gpgcheck=1
enabled=1
gpgkey=https://pgp.mongodb.com/server-7.0.asc
Paste the following into /etc/yum.repos.d/mongodb-org-7.0.repo (edit the /8/ to /9/ if you're using Rocky 9):
```ini
[mongodb-org-7.0]
name=MongoDB Repository
baseurl=https://repo.mongodb.org/yum/redhat/8/mongodb-org/7.0/x86_64/
gpgcheck=1
enabled=1
gpgkey=https://pgp.mongodb.com/server-7.0.asc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've committed all the suggested changes you proposed, thanks for making them. I had to play around with the formatting on this suggestion and settled on the changes in f82776c. Can you take a look and make sure you're happy with how it looks please?

docs/mongodb.md Outdated Show resolved Hide resolved
yum install mongodb-org
# Start MongoDB, enter the shell and check the "Using MongoDB:" line lists a version 7.x.x
systemctl start mongod
mongosh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ingest won't work because we need mongosh but we're still using mongo until #120 is merged. I'd consider this blocked until that's merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, let's leave this unresolved so I remember to not merge this until the other PR is merged.

MRichards99 and others added 2 commits May 29, 2024 15:14
Co-authored-by: patrick-austin <61705287+patrick-austin@users.noreply.github.com>
Copy link
Contributor

@patrick-austin patrick-austin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another incredibly pedantic change request (the real problem is I think the language support / syntax highlighting feature is really cool so I can't overlook and opportunity to use it- even when it really doesn't matter...)

docs/mongodb.md Outdated
[mongodb-org-7.0]
name=MongoDB Repository
baseurl=https://repo.mongodb.org/yum/redhat/8/mongodb-org/7.0/x86_64/
gpgcheck=1
enabled=1
gpgkey=https://pgp.mongodb.com/server-7.0.asc

```
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```
```bash

Really minor, we can use the bash language support for this block like the first one (practically I think the only difference is it will gray out the comments). Appreciate this was probably missing from my suggested change because it struggles with nesting back ticks inside the suggestion backtick box.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, I like to use them too but forgot about it in that case. Committed your suggestion

Co-authored-by: patrick-austin <61705287+patrick-austin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants