Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-314 centroid support #117

Draft
wants to merge 1 commit into
base: 288_lark_functions
Choose a base branch
from

Conversation

patrick-austin
Copy link
Contributor

Branched from main functions branch, so dependent on #86 being merged. Alternatively, could target that branch and merge into that before merging #86

Adds endpoint for getting crosshairs information from an image. Position is optional, if not provided then the centroid will be determined and used as the position for the crosshairs (with these co-ords being returned). In either case, the pixel values for that row and column will be returned using the WaveformModel format and the fwhm of that signal.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.06259% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 92.80%. Comparing base (db0cc7e) to head (2c436ed).

Files Patch % Lines
...perationsgateway_api/src/records/export_handler.py 89.74% 1 Missing and 3 partials ⚠️
operationsgateway_api/src/records/record.py 97.36% 1 Missing and 2 partials ⚠️
operationsgateway_api/src/routes/functions.py 95.83% 1 Missing and 1 partial ⚠️
operationsgateway_api/src/routes/images.py 92.59% 0 Missing and 2 partials ⚠️
operationsgateway_api/src/records/image.py 94.44% 0 Missing and 1 partial ⚠️
operationsgateway_api/src/routes/waveforms.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #117      +/-   ##
==========================================
+ Coverage   91.33%   92.80%   +1.47%     
==========================================
  Files          47       67      +20     
  Lines        2446     3099     +653     
  Branches      197      266      +69     
==========================================
+ Hits         2234     2876     +642     
- Misses        186      188       +2     
- Partials       26       35       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MRichards99
Copy link
Collaborator

Re your explanation at the top in bold, I've got a suggestion that'll make this PR easier to review.

  1. Both this PR and DSEGOG-289 DSEGOG-291 DSEGOG-292 DSEGOG-293 DSEGOG-290 Implement functions with Lark #86 have merge conflicts (only poetry.lock, so simple to resolve) resolve the merge conflicts in your branch on DSEGOG-289 DSEGOG-291 DSEGOG-292 DSEGOG-293 DSEGOG-290 Implement functions with Lark #86
  2. Merge 288_lark_functions into DSEG-OG-314-centroid_support to get the conflict resolutions from above
  3. Change the target branch on this PR from main to 288_lark_functions - this will clean up the view of this PR because currently it contains all the changes from your original functions PR. So unless you've intensely studied the other PR, it's currently unclear whether the code is new or it's part of the other functions PR

@patrick-austin patrick-austin changed the base branch from main to 288_lark_functions May 7, 2024 10:08
@louise-davies louise-davies changed the title Dseg og 314 centroid support DSEGOG-314 centroid support May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants