DSEGOG-307 Kill API Instances Cleanly in Echo Ingest Script #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to improve the Echo ingestion script. It used to not kill the API at the end of the script so the processes needed to be manually killed - the problem would often occur when you launch the API using
poetry run
and it would complain the address is already in use.To make this better, the kill function now uses
lsof
to pinpoint all processes attached to the port used for the API, puts those PIDs into a list and uses the standard libraryos.kill()
to kill them one by one.