Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call cross_compiling block for native platform too #171

Closed
wants to merge 1 commit into from

Commits on Mar 3, 2020

  1. Call cross_compiling block for native platform too

    Currently the cross_compiling block isn't called when cross compiling for the build platform.
    This is due to the fact that define_native_tasks() is called first for the build platform
    and later on for the cross platforms. The task "native:<gemname>:<platform>" is defined
    only once and therefore only without the callback. The callback is therefore not called
    for the cross platform that equals the build platform.
    
    OMHO the root issue is that rake-compiler doesn't has a clear separation between
    native and cross tasks. However I think calling cross_compiling for any binary gem
    (native or cross) is a suitable workaround.
    
    This fixes bug sparklemotion/nokogiri#1991 (comment)
    larskanis committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    c974a8b View commit details
    Browse the repository at this point in the history