Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct required_ruby_version when some RUBY_CC_VERSIONs are missing #198

Closed
larskanis opened this issue Jan 12, 2022 · 0 comments · Fixed by #199
Closed

Set correct required_ruby_version when some RUBY_CC_VERSIONs are missing #198

larskanis opened this issue Jan 12, 2022 · 0 comments · Fixed by #199

Comments

@larskanis
Copy link
Member

This was raised by @flavorjones in sparklemotion/nokogiri#2409 (comment) .

When RUBY_CC_VERSION has some ruby version that are not available as cross compile platforms, they are simply ignored for building the gem. In this case it just shows the warning no configuration section for specified version of Ruby (rbconfig-x64-mingw32-2.3.3) or similar. However it turned out, that the versions defined in RUBY_CC_VERSION are still respected in the required_ruby_version of the resulting gemspec, although no such binaries have been built.

The issue happens practically in rake-compiler-dock which has added the new platform "x64-mingw-ucrt" which supports only ruby-3.1. On the other hand the "x64-mingw32" doesn't support ruby-3.1, but only ruby-2.4 to 3.0. This is in accordance to the change of RubyInstaller-3.1. RUBY_CC_VERSION is set to 3.1.0:3.0.0:2.7.0:2.6.0:2.5.0:2.4.0 in any case. The resulting gems should reflect the version range of the given platform, but both platform gemspecs actually state ruby-2.4 to 3.1 compatibility, currently.
larskanis added a commit to larskanis/rake-compiler that referenced this issue Jan 12, 2022
@larskanis
Set correct required_ruby_version when some RUBY_CC_VERSIONs are …
e97cd31 
…missing

The required_ruby_version was set twice, although one in define_native_tasks is enough.

Fixes rake-compiler#198
@larskanis larskanis mentioned this issue Jan 12, 2022
Merged
@kou kou closed this as completed in #199 Jan 17, 2022
kou pushed a commit that referenced this issue Jan 17, 2022
@larskanis
Set correct required_ruby_version when some RUBY_CC_VERSIONs are …
2b67583 
…missing (#199)

The required_ruby_version was set twice, although one in define_native_tasks is enough.

Fixes #198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set correct required_ruby_version when some RUBY_CC_VERSIONs are missing larskanis/rake-compiler
1 participant
@larskanis