darwin: work around the Ruby 3.2 symbol resolution changes #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to demonstrate the failing test
|
@larskanis I've also tested this with the sqlite3-ruby gem and it works. I think we should merge this, do you have any feedback on it? |
larskanis
approved these changes
Jan 4, 2023
flavorjones
added a commit
to sparklemotion/sqlite3-ruby
that referenced
this pull request
Jan 4, 2023
This works around new Darwin Ruby 3.2 symbol resolution issues, but also follows best practices around shipping shared libraries. Note that we remove the `-flat_namespace` hack because the latest rake-compiler-docker images have the changes from rake-compiler/rake-compiler-dock#94
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the
-Wl,-flat_namespacelinker flag into the Darwin Ruby 3.2 build environments.Context
See lengthy conversations at these issues for context
After building RCs of precompiled gems for both nokogiri and sqlite3, I found that I needed to add this flag in order for the extension to be able to resolve basic symbols like
rb_cObjectwhen running against a version of Ruby compiled with the--enable-sharedconfig flag.I cannot imagine any scenario where someone would be precompiling a Ruby 3.2 Darwin bundle and not want this flag on given the current state of the universe.
Details