add regression tests for phpstan/phpstan#7000

rajyan · May 11, 2022 · 9381526 · 9381526
1 parent 43cb6ab
commit 9381526
Show file tree

Hide file tree

Showing 4 changed files with 46 additions and 0 deletions.
diff --git a/tests/PHPStan/Analyser/NodeScopeResolverTest.php b/tests/PHPStan/Analyser/NodeScopeResolverTest.php
@@ -879,6 +879,7 @@ public function dataFileAsserts(): iterable
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-3853.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/conditional-types.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/constant-array-optional-set.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7000.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-6383.php');
 		yield from $this->gatherAssertTypes(__DIR__ . '/../Rules/Methods/data/bug-3284.php');
 

diff --git a/tests/PHPStan/Analyser/data/bug-7000.php b/tests/PHPStan/Analyser/data/bug-7000.php
@@ -0,0 +1,20 @@
+<?php
+
+namespace Bug7000;
+
+use function PHPStan\Testing\assertType;
+
+class Foo
+{
+	public function doBar(): void
+	{
+		/** @var array{require?: array<string, string>, require-dev?: array<string, string>} $composer */
+		$composer = array();
+		foreach (array('require', 'require-dev') as $linkType) {
+			if (isset($composer[$linkType])) {
+				assertType('array{require?: array<string, string>, require-dev?: array<string, string>}&non-empty-array', $composer);
+				foreach ($composer[$linkType] as $x) {}
+			}
+		}
+	}
+}
diff --git a/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php b/tests/PHPStan/Rules/Arrays/NonexistentOffsetInArrayDimFetchRuleTest.php
@@ -385,4 +385,9 @@ public function testBug4885(): void
 		$this->analyse([__DIR__ . '/data/bug-4885.php'], []);
 	}
 
+	public function testBug7000(): void
+	{
+		$this->analyse([__DIR__ . '/data/bug-7000.php'], []);
+	}
+
 }
diff --git a/tests/PHPStan/Rules/Arrays/data/bug-7000.php b/tests/PHPStan/Rules/Arrays/data/bug-7000.php
@@ -0,0 +1,20 @@
+<?php declare(strict_types = 1);
+
+namespace Bug7000;
+
+class Foo
+{
+	public function doBar(): void
+	{
+		/** @var array{require?: array<string, string>, require-dev?: array<string, string>} $composer */
+		$composer = array();
+		/** @var 'require'|'require-dev' $foo */
+		$foo = '';
+		foreach (array('require', 'require-dev') as $linkType) {
+			if (isset($composer[$linkType])) {
+				foreach ($composer[$linkType] as $x) {} // should not report error
+				foreach ($composer[$foo] as $x) {} // should report error. It can be $linkType = 'require', $foo = 'require-dev'
+			}
+		}
+	}
+}