forked from dotnet/msbuild
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Introduce IsAllFilesWildcard() and call it from MatchFileRecursionStep
Fixes dotnet#6502 Summary This change fixes a regression in glob matching where files without extension are erroneously not matched when taking a specific globbing code path. Customer impact Any customer who uses a glob pattern susceptible to the bug and has files without extensions in their source tree is affected. The bug was reported by external customers. Regression? Yes, caused by dotnet#6151 where glob matching was optimized which internally made it take a different code path. Changes Made Fixes the regression by properly handling `*.*` to mean all files, not just files with a dot in the name. This convention is used in .NET APIs on all platforms and matches the pre-regression behavior. Testing Added unit test coverage. Also verified locally with the repro provided by the original bug reporter. Risk Low. The star patterns are special-cased to mean all files, other patterns are unaffected.
- Loading branch information
1 parent
2fd48ab
commit de3f28e
Showing
2 changed files
with
45 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters