Reduce bundle size further more #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raineorshine
requested changes
Apr 11, 2024
| @@ -0,0 +1,34 @@ | |||
| // vite.config.mts | |||
There was a problem hiding this comment.
This file appears to have been accidentally added to version control.
There was a problem hiding this comment.
Oh!
This file is an intermediate file created by vite, it should have been deleted by vite after the build, I must have aborted the process somehow and it leaks to the PR.
There was a problem hiding this comment.
Removed in fd881ba (#1397).
raineorshine
force-pushed
the
reduce-bundle-size
branch
from
fd881ba
to
7b00844
Compare
raineorshine
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR follows #1394 and #1396.
The PR does the following things:
lodash/cloneDeepwith https://npm.im/rfdclodash/isEqualwith https://npm.im/dequallodash/pick,lodash/pickBy, andlodash/sortBywith self-implemented methodsmake-fetch-happennpm-check-updatesnow target Node.js 18+, let's use Node.js built-inglobalThisfetch.Another 250 KiB of installation size would be reduced by the PR.