spawnYarn: args must go after yarn options (#1362).

raineorshine · Jan 25, 2024 · 3679b1a · 3679b1a
1 parent c657e25
commit 3679b1a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/package-managers/bun.ts b/src/package-managers/bun.ts
@@ -22,9 +22,9 @@ async function spawnBun(
   args = Array.isArray(args) ? args : [args]
 
   const fullArgs = [
-    ...args,
     ...(npmOptions.prefix ? `--prefix=${npmOptions.prefix}` : []),
     ...(npmOptions.global ? ['--global'] : []),
+    ...args,
   ]
 
   return spawn('bun', fullArgs, spawnOptions)

diff --git a/src/package-managers/npm.ts b/src/package-managers/npm.ts
@@ -539,10 +539,10 @@ async function spawnNpm(
   args = Array.isArray(args) ? args : [args]
 
   const fullArgs = [
-    ...args,
     ...(npmOptions.global ? [`--global`] : []),
     ...(npmOptions.prefix ? [`--prefix=${npmOptions.prefix}`] : []),
     '--json',
+    ...args,
   ]
   return spawn(cmd, fullArgs, spawnOptions)
 }

diff --git a/src/package-managers/yarn.ts b/src/package-managers/yarn.ts
@@ -196,11 +196,12 @@ async function spawnYarn(
 
   const fullArgs = [
     ...(yarnOptions.global ? 'global' : []),
-    ...(Array.isArray(args) ? args : [args]),
     '--depth=0',
     ...(yarnOptions.prefix ? `--prefix=${yarnOptions.prefix}` : []),
     '--json',
     '--no-progress',
+    // args must go after yarn options, otherwise they are passed through to npm scripts
+    ...(Array.isArray(args) ? args : [args]),
   ]
 
   return spawn(cmd, fullArgs, spawnOptions)