Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browser: release fixes #5721

Merged
merged 10 commits into from
May 14, 2024
Merged

Browser: release fixes #5721

merged 10 commits into from
May 14, 2024

Conversation

christianbaroni
Copy link
Member

What changed (plus any additional context for devs)

  • Fixes ScrollView jitter that previously occurred when closing tabs, and on Android when zooming into tabs
  • Fixes control panel wallet list sorting — new ordering:
    • Imported/hardware wallets (from highest balance to lowest)
    • Watched wallets (also adds “Watching” labels)
  • Fixes initial tab view scroll position
  • Fixes tearing when creating new tabs
  • Improves disabled control panel button styles
  • Disables the “Favorite” control panel button on the homepage
  • Improves tab closing animations
  • Adds a few missing i18n strings
  • Removes unnecessary usages of React.memo where it was used on components that aren’t susceptible to re-renders
  • Fixes Android homepage card layout
  • Fixes Android search input text alignment
  • Improves background contrast in the light mode tab view
  • Fixes bugs causing delays when blurring the search input
  • Replaces several instances of useSyncSharedValue with useSharedValueState
  • Misc. performance improvements, re-render narrowing

(Fixes verified on both iOS and Android)

Screen recordings / screenshots

What to test

skylarbarrera
skylarbarrera approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@skylarbarrera skylarbarrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/components/DappBrowser/BrowserTab.tsx Show resolved Hide resolved
@christianbaroni christianbaroni merged commit 618e441 into develop May 14, 2024
6 checks passed
@christianbaroni christianbaroni deleted the @christian/browser-release branch May 14, 2024 18:12
BrodyHughes added a commit that referenced this pull request May 21, 2024
@BrodyHughes
Merge branch 'develop' of github.com:rainbow-me/rainbow into brody/fi…
948f430 
…x-qr-code-sheet

* 'develop' of github.com:rainbow-me/rainbow: (56 commits)
  review panel fixes (#5747)
  Account for NaN values on sliderPosition (#5741)
  add myself to CO for PR approvals (#5743)
  bump version to v1.9.24 (#5742)
  Asset Prices (#5724)
  rm references to old redux swaps const (#5740)
  Swap Warning / Price Impact component (#5722)
  add animated coin icons and text fallbacks (#5733)
  adds ability to select a different output chain id (#5727)
  fix (#5738)
  fix positions calling without address (#5729)
  disable button (#5725)
  Browser: homepage empty state, search logic fixes (#5737)
  Add privacy manifest (#5736)
  swaps and bridge checks on control panel (#5735)
  Browser: fix control panel crash (#5734)
  Browser: control panel fixes (#5730)
  f skylar (#5732)
  fix account switching (#5726)
  Browser: release fixes (#5721)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skylarbarrera skylarbarrera skylarbarrera approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79 brunobar79 is a code owner

@benisgold benisgold Awaiting requested review from benisgold benisgold is a code owner

Assignees
No one assigned
Labels
dapp browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@christianbaroni @skylarbarrera @jinchung