Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swaps: Refactor favorites logic in CoinRow #5682

Closed
wants to merge 3 commits into from
Closed

Swaps: Refactor favorites logic in CoinRow #5682

wants to merge 3 commits into from

Conversation

benisgold
Copy link
Member

@benisgold benisgold commented Apr 30, 2024 •
edited

Fixes APP-1352

What changed (plus any additional context for devs)

  • removes useFavorites hook usage from CoinRow
  • pass in isFavorite as prop to CoinRow (based on section id) to eliminate state usage

Screen recordings / screenshots

What to test

@linear Linear
Copy link

linear bot commented Apr 30, 2024

APP-1352 Minimize CoinRow re-renders (due to favorites)

@benisgold benisgold requested a review from walmat April 30, 2024 23:21
@benisgold benisgold marked this pull request as ready for review May 1, 2024 16:24
@benisgold benisgold requested a review from walmat May 1, 2024 16:24
@benisgold benisgold closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat Awaiting requested review from walmat

Assignees
No one assigned
Labels
swaps v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benisgold @walmat @jinchung