Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dynamic island overlap on recieve modal #5672

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

BrodyHughes
Copy link
Member

@BrodyHughes BrodyHughes commented Apr 26, 2024

Fixes APP-950

What changed (plus any additional context for devs)

  • moved to SimpleSheet and changed the route to use similar route settings that we use for other sheets

Screen recordings / screenshots

Before:
Screenshot 2024-04-26 at 12 39 18 PM
After:

Screen.Recording.2024-04-26.at.1.07.33.PM.mov

@BrodyHughes BrodyHughes changed the title qr sheet fix dynamic island overlap on recieve modal Apr 26, 2024
Copy link

linear bot commented Apr 26, 2024

@BrodyHughes BrodyHughes marked this pull request as ready for review April 26, 2024 18:11
@BrodyHughes BrodyHughes requested a review from walmat April 26, 2024 18:11
src/screens/ReceiveModal.js Outdated Show resolved Hide resolved
src/screens/ReceiveModal.js Outdated Show resolved Hide resolved
…x-qr-code-sheet

* 'develop' of github.com:rainbow-me/rainbow: (56 commits)
  review panel fixes (#5747)
  Account for NaN values on sliderPosition (#5741)
  add myself to CO for PR approvals (#5743)
  bump version to v1.9.24 (#5742)
  Asset Prices (#5724)
  rm references to old redux swaps const (#5740)
  Swap Warning / Price Impact component (#5722)
  add animated coin icons and text fallbacks (#5733)
  adds ability to select a different output chain id (#5727)
  fix (#5738)
  fix positions calling without address (#5729)
  disable button (#5725)
  Browser: homepage empty state, search logic fixes (#5737)
  Add privacy manifest (#5736)
  swaps and bridge checks on control panel (#5735)
  Browser: fix control panel crash (#5734)
  Browser: control panel fixes (#5730)
  f skylar (#5732)
  fix account switching (#5726)
  Browser: release fixes (#5721)
  ...
@BrodyHughes BrodyHughes requested a review from walmat May 23, 2024 20:30
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smol ting but otherwise 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants