Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backups v2 IDFA check #5653

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Backups v2 IDFA check #5653

wants to merge 9 commits into from

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Apr 22, 2024

Fixes APP-1188

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Copy link

linear bot commented Apr 22, 2024

@walmat walmat marked this pull request as draft April 22, 2024 18:59
@walmat walmat marked this pull request as ready for review May 3, 2024 16:39
src/model/backup.ts Outdated Show resolved Hide resolved
src/model/backup.ts Outdated Show resolved Hide resolved
src/model/backup.ts Outdated Show resolved Hide resolved
src/model/backup.ts Show resolved Hide resolved
src/screens/CheckIdentifierScreen.tsx Outdated Show resolved Hide resolved
src/screens/CheckIdentifierScreen.tsx Outdated Show resolved Hide resolved
@walmat walmat requested a review from brunobar79 May 6, 2024 17:23
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left 2 minor comments otherwise LGTM!

ios/RCTDeviceUUID.m Outdated Show resolved Hide resolved
src/screens/CheckIdentifierScreen.tsx Outdated Show resolved Hide resolved
@jinchung jinchung removed the request for review from skylarbarrera May 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants