Replace App raps with BX #5608
Merged
Replace App raps with BX #5608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
walmat
requested review from
jinchung and
skylarbarrera
and removed request for
jinchung
skylarbarrera
suggested changes
Apr 9, 2024
| resolve(); | ||
| } else { | ||
| // Wait for 1 second and try again | ||
| await delay(1000); |
There was a problem hiding this comment.
this seems slow to me 🤔
There was a problem hiding this comment.
can bump it up, just what the BX had
|
Replaced new gas store with old redux gas. Will rip old redux stuff out in a future PR. |
walmat
removed
the
blocked
benisgold
approved these changes
Apr 24, 2024
|
|
||
| const waitForNodeAck = async (hash: string, provider: Signer['provider']): Promise<void> => { | ||
| return new Promise(async resolve => { | ||
| const tx = await provider?.getTransaction(hash); |
There was a problem hiding this comment.
why not provider.waitForTransaction?
https://docs.ethers.org/v5/api/providers/provider/#Provider-waitForTransaction
There was a problem hiding this comment.
We could use that and wait for 1 confirmation, however for the sake of keeping code parity between app <> bx I didn't change any of the raps (functionally).
skylarbarrera
approved these changes
May 14, 2024
|
tested all raps entry points and they worked as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1311
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-04-08.at.17.25.16.mp4