Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude flipper deps from release builds #556

Merged
merged 1 commit into from Apr 15, 2020

Conversation

brunobar79
Copy link
Member

Initially on RN 0.62 the recommended flipper integration was accidentally including all the transitive deps into release builds. This PR fixes this (same as facebook/react-native#28504)

Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@mikedemarais mikedemarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@brunobar79 brunobar79 merged commit 6ab42bc into develop Apr 15, 2020
@brunobar79 brunobar79 deleted the @bruno/exclude-flipper-deps-from-release-builds branch April 15, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants