Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RDS colors #5515

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Fix RDS colors #5515

wants to merge 19 commits into from

Conversation

benisgold
Copy link
Member

Fixes APP-####

What changed (plus any additional context for devs)

  • fixed RDS colors
  • adjusted some old components to match new colors
  • far from perfect but better than before

Screen recordings / screenshots

What to test

dereknelson
dereknelson approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@dereknelson dereknelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

making crypto more colorful one # at a time

walmat
walmat requested changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. There are some discrepancies between some of the UI in figma and here still. Mostly bottom tab bar, some of the sheet background colors, etc. This is definitely an improvement but I think it's all or nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat requested changes

@dereknelson dereknelson dereknelson approved these changes

@christianbaroni christianbaroni Awaiting requested review from christianbaroni

@skylarbarrera skylarbarrera Awaiting requested review from skylarbarrera

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benisgold @walmat @dereknelson