Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix images detection issues for file_upload types #3633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Laith-jalal
Copy link

@Laith-jalal Laith-jalal commented Jun 22, 2023

This PR fixes an issue for the FileUpload type especially for the :image? instance_option,
some file uploading Gems add a query string part to the file/image URL, paperclip for example adds timestamp value to the file's URL and in the current implementation having query string will result in NOT considering the file as an image even when it's an image

@coveralls
Copy link

Coverage Status

coverage: 95.866% (+0.001%) from 95.865% when pulling d209b87 on Laith-jalal:fix_file_upload_images_detection_issue into 647347c on railsadminteam:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants