New 5.x release #2900
Closed
New 5.x release #2900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorshea
reviewed
Jan 29, 2021
|
|
||
| say "Installing dev server for live reloading" | ||
| run "yarn add --dev webpack-dev-server" | ||
| run "yarn add --dev webpack-dev-server@3.x" | ||
|
|
||
| if Rails::VERSION::MAJOR == 5 && Rails::VERSION::MINOR > 1 |
There was a problem hiding this comment.
shouldn't this also show up on Rails 6 and 6.1?
|
@gauravtiwari I'd like to backport #2734 to 5.x but I'm not clear of the process and couldn't find any documentation, should I cherry-pick it into this PR? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds necessary updates for 5.x and makes it stable so it works properly with webpack cli and dev server.