Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove yarn integrity check #2518

Merged
merged 3 commits into from Apr 11, 2020
Merged

Remove yarn integrity check #2518

merged 3 commits into from Apr 11, 2020

Commits on Apr 1, 2020

  1. Remove the yarn integrity check 

    The `yarn check` command has been removed in Yarn 2.0.

The yarn integrity check in Webpacker has commonly been a source of
confusion and frustration among developers. Its behavior at times does
not always match expectation.

Yarn's maintainer has described `yarn check` as buggy and discourages
its use: yarnpkg/yarn#6427 (comment)

This PR removes the yarn integrity check from the Webpacker railtie as
well as references to its setting in Webpacker::Configuration.

The Webpacker::Configuration#check_yarn_integrity= method has been left
in with a deprecation warning to avoid a breaking change.
    @rossta
    rossta committed Apr 1, 2020
    Copy the full SHA
    4538582 View commit details
    Browse the repository at this point in the history

  2. Add deployment note in README 

    It's recommended to use `yarn install --frozen-lockfile` in a deployment
context prior to compiling assets for production. This practice may help
offset potential concerns with the removal of the yarn integrity check,
at least in production environemnts.
    @rossta
    rossta committed Apr 1, 2020
    Copy the full SHA
    aacd95c View commit details
    Browse the repository at this point in the history

  3. Update README with note about yarn install

    @rossta
    rossta committed Apr 1, 2020
    Copy the full SHA
    3f6e016 View commit details
    Browse the repository at this point in the history