Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clean task simpler and fix issues #2389

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Conversation

gauravtiwari
Copy link
Member

@gauravtiwari gauravtiwari commented Dec 9, 2019

This PR makes clean task simpler, without reliance on regex, which are hard to reason and also a bit brittle. Also, noticed the previous implementation didn't remove some files.

The clean task will always preserve, the latest version and a backup version in the packs folder.

Closes #2384
Closes #2382
Closes #2385
Fixes #2372

@gauravtiwari
Copy link
Member Author

If someone could review this and will merge later today and make a new release.

Tidy up

Compact

Update message

Remove message

Inline
@gauravtiwari gauravtiwari merged commit 6427cdb into master Dec 9, 2019
@gauravtiwari gauravtiwari deleted the fix-clean-task branch December 9, 2019 09:17
@tachyons
Copy link
Contributor

tachyons commented Dec 9, 2019

Since the previous version broke the assets:clean workflow. Releasing this early as possible will be great

@gauravtiwari
Copy link
Member Author

Already released @tachyons 4.2.1

@thomasdarde
Copy link

We were seeing the cleanup_assets error on random basis with 4.2.0, with 4.2.1 we have it on each deploy.

@tachyons
Copy link
Contributor

tachyons commented Dec 9, 2019

Yes, 4.2.1 broken for us too

@tachyons
Copy link
Contributor

tachyons commented Dec 9, 2019

Made a quick fix here #2391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New webpacker:clean task raises 'No such file or directory' error
3 participants