Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert of production env enforcement #2341

Merged
merged 7 commits into from Nov 7, 2019
Merged

Revert of production env enforcement #2341

merged 7 commits into from Nov 7, 2019

Commits on Oct 30, 2019

  1. Revert d8dd446 

    Undoing the commit that forces the production environment. The code has it as default when not defined, this is sufficient, but it should respect the user settings!

Resolves #2340
    @coding-bunny
    coding-bunny committed Oct 30, 2019
    Copy the full SHA
    fc57a00 View commit details
    Browse the repository at this point in the history

  2. Update compile.rake 

    use proper indentation
    @coding-bunny
    coding-bunny committed Oct 30, 2019
    Copy the full SHA
    0cd8dfb View commit details
    Browse the repository at this point in the history

  3. Update rake_tasks_test.rb 

    Removed call to `with_node_env` and assume production by default.
    @coding-bunny
    coding-bunny committed Oct 30, 2019
    Copy the full SHA
    976fc9c View commit details
    Browse the repository at this point in the history

  4. Update rake_tasks_test.rb 

    updated failing tests to reflect changes made.
    @coding-bunny
    coding-bunny committed Oct 30, 2019
    Copy the full SHA
    293263b View commit details
    Browse the repository at this point in the history

  5. Update rake_tasks_test.rb 

    inject the ENV over command line
    @coding-bunny
    coding-bunny committed Oct 30, 2019
    Copy the full SHA
    efd4225 View commit details
    Browse the repository at this point in the history

  6. Update rake_tasks_test.rb 

    trying to fix RuboCop
    @coding-bunny
    coding-bunny committed Oct 30, 2019
    Copy the full SHA
    6974048 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2019

  1. Using @rossta solution to combine both behaviors

    Arne De Herdt committed Nov 7, 2019
    Copy the full SHA
    88be57f View commit details
    Browse the repository at this point in the history