Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed crash because hashes in manifest #2315

Closed
wants to merge 1 commit into from
Closed

Fixed crash because hashes in manifest #2315

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 7, 2019

#2310

I don't know when it started, but suddenly manifest.refresh looks like this:

{"admin.css"=>"/packs/css/admin-d3529850.css",
 "admin.css.map"=>"/packs/css/admin-d3529850.css.map",
 "admin.js"=>"/packs/js/admin-8154656c0ed71f08e58a.js",
 "admin.js.map"=>"/packs/js/admin-8154656c0ed71f08e58a.js.map",
 "application.css"=>"/packs/css/application-1a6d2f16.css",
 "application.css.map"=>"/packs/css/application-1a6d2f16.css.map",
 "application.js"=>"/packs/js/application-9cf597e6a5fda80f7ef6.js",
 "application.js.map"=>"/packs/js/application-9cf597e6a5fda80f7ef6.js.map",
 "entrypoints"=>
  {"admin"=>
    {"css"=>["/packs/css/admin-d3529850.css"],
     "js"=>["/packs/js/admin-8154656c0ed71f08e58a.js"],
     "css.map"=>["/packs/css/admin-d3529850.css.map"],
     "js.map"=>["/packs/js/admin-8154656c0ed71f08e58a.js.map"]},
   "application"=>
    {"css"=>["/packs/css/application-1a6d2f16.css"],
     "js"=>["/packs/js/application-9cf597e6a5fda80f7ef6.js"],
     "css.map"=>["/packs/css/application-1a6d2f16.css.map"],
     "js.map"=>["/packs/js/application-9cf597e6a5fda80f7ef6.js.map"]},
   "react-admin"=>
    {"css"=>["/packs/css/react-admin-118ff3ab.css"],
     "js"=>["/packs/js/react-admin-67e94b0c2d17edf0971a.js"],
     "css.map"=>["/packs/css/react-admin-118ff3ab.css.map"],
     "js.map"=>["/packs/js/react-admin-67e94b0c2d17edf0971a.js.map"]},
   "react"=>
    {"css"=>["/packs/css/react-6feaf6dd.css"],
     "js"=>["/packs/js/react-8f3f1f8ef222ed4afe23.js"],
     "css.map"=>["/packs/css/react-6feaf6dd.css.map"],
     "js.map"=>["/packs/js/react-8f3f1f8ef222ed4afe23.js.map"]}},
 "media/components/teams/selector/individual.svg"=>
  "/packs/media/components/teams/selector/individual-e7bde83c29b3ad8270281399117c137d.svg",
 "media/components/teams/selector/team.svg"=>
  "/packs/media/components/teams/selector/team-fb1d7d24fea427555c0380aeff71c44b.svg",
 "media/images/hr.png"=>
  "/packs/media/images/hr-111cfb16a7f6e7ba506c006a2ec9b49a.png",
 "react-admin.css"=>"/packs/css/react-admin-118ff3ab.css",
 "react-admin.css.map"=>"/packs/css/react-admin-118ff3ab.css.map",
 "react-admin.js"=>"/packs/js/react-admin-67e94b0c2d17edf0971a.js",
 "react-admin.js.map"=>"/packs/js/react-admin-67e94b0c2d17edf0971a.js.map",
 "react.css"=>"/packs/css/react-6feaf6dd.css",
 "react.css.map"=>"/packs/css/react-6feaf6dd.css.map",
 "react.js"=>"/packs/js/react-8f3f1f8ef222ed4afe23.js",
 "react.js.map"=>"/packs/js/react-8f3f1f8ef222ed4afe23.js.map"}

Notice the nested hashes in there. That needs to be parsed before used with File.join.

@gauravtiwari
Copy link
Member

Thanks but fixed in #2318

@ghost ghost deleted the fixed-crash-because-hashes-in-manifest branch November 12, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant