Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added favicon_pack_tag to generate favicon links #2281

Merged
merged 1 commit into from Sep 18, 2019
Merged

Added favicon_pack_tag to generate favicon links #2281

merged 1 commit into from Sep 18, 2019

Conversation

kpumuk
Copy link
Contributor

@kpumuk kpumuk commented Sep 10, 2019

There is no way at the moment to generate a favicon link that uses a webpacker managed image. This PR adds favicon_pack_tag that behaves in a similar way to image_pack_tag, but instead of an image tag, it produces a favicon link.

@gauravtiwari gauravtiwari merged commit 3c117c0 into rails:master Sep 18, 2019
@gauravtiwari
Copy link
Member

thanks @kpumuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants