Add CSS Module support. #1248
Merged
Add CSS Module support. #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tai2
force-pushed
the
css-modules-by-suffix
branch
2 times, most recently
from
d9ef2e6
to
e82cb5e
Compare
gauravtiwari
reviewed
Feb 7, 2018
package/rules/style_rule_factory.js
Outdated
| const inlineCSSLoader = { | ||
| test, | ||
| use: [styleLoader].concat(extractOptions.use), | ||
| ...modulesCondition |
There was a problem hiding this comment.
You will probably need to use Object.assign here since object spread isn't supported in 6.x: http://node.green/#ES2018-features-object-rest-spread-properties-object-rest-properties
gauravtiwari
reviewed
Feb 7, 2018
package/rules/style_rule_factory.js
Outdated
| const extractCSSLoader = { | ||
| test, | ||
| use: ExtractTextPlugin.extract(extractOptions), | ||
| ...modulesCondition |
There was a problem hiding this comment.
gauravtiwari
reviewed
Feb 7, 2018
docs/css.md
Outdated
| @@ -6,10 +6,12 @@ Webpacker supports importing CSS, Sass and SCSS files directly into your JavaScr | |||
|
|
|||
| ## Import styles into your JS app | |||
|
|
|||
| Stylesheets end with '.modules.*' is treated as [CSS Modules](https://github.com/css-modules/css-modules). | |||
There was a problem hiding this comment.
Could we please make a new documentation for this? We still support regular sass or css imports without css modules.
tai2
force-pushed
the
css-modules-by-suffix
branch
from
d3d6561
to
2021330
Compare
|
Fixed |
|
thanks @tai2 Will take a look at this soon. |
|
thanks @tai2 for this 🍰 💯 |
gbp
added a commit
to mysociety/verification-pages
that referenced
this pull request
Jul 6, 2018
Taken from: rails/webpacker#1248
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat some file names like
.module.cssas CSS Modules.This naming convention is adopted by some other OSSs such create-react-app or poi.