Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compression-webpack-plugin and serialize-javascript@^1.4.0 dependency #2387

Closed
WillHen opened this issue Dec 6, 2019 · 5 comments
Closed

Comments

@WillHen
Copy link

WillHen commented Dec 6, 2019

One of this repros dependancies (compression-webpack-plugin) has a dependency of serialize-javascript@^1.4.0 which has a known issue GHSA-h9rv-jmmf-4pgx .
The compression-webpack-plugin repro has not been updated in 6 months, someone has submitted a PR to fix the issue and upgrade serialize-javascript but it has not been approved or merged as of yet.

Is it possible to move away from compression-webpack-plugin?

@clearyandzap
Copy link

compression-webpack-plugin has made a fix webpack-contrib/compression-webpack-plugin#139

@vfonic
Copy link
Contributor

vfonic commented Dec 15, 2019

This should fix the issue:
yarn upgrade "terser-webpack-plugin@^1.4.1"

After this, run yarn audit to make sure there are no known security issues in your project dependencies.

@Yenwod
Copy link

Yenwod commented Feb 29, 2020

To pickup the fix mentioned by @clearyandzap, this worked for me:

$ yarn upgrade "@rails/webpacker@^4.2.2"
$ yarn audit

Yarn audit confirmed the fix.

bunnymatic pushed a commit to carbonfive/raygun-rails that referenced this issue Mar 10, 2020
Problem
----------

`@rails/webpacker` had security issues in dependencies of dependencies.

Read more here
![GHSA-h9rv-jmmf-4pgx
](GHSA-h9rv-jmmf-4pgx)
 and here
rails/webpacker#2387

Solution
--------

Upgrade `@rails/webpacker`
@guillaumebriday
Copy link
Member

Is this issue can be closed ?

@Levii01
Copy link

Levii01 commented Aug 27, 2020

@Yenwod solution works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants