Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addresses minimist and serialize-javascript vulnerabilities #563

Merged
merged 6 commits into from
May 18, 2020

Conversation

banukutlu
Copy link
Contributor

No description provided.

@banukutlu banukutlu added this to the 0.3.x Clean Up milestone Apr 15, 2020
@banukutlu banukutlu self-assigned this Apr 15, 2020
Copy link
Contributor

@cdmo cdmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had to upgrade webpacker to fix these?

@banukutlu
Copy link
Contributor Author

we had to upgrade webpacker to fix these?

yeah, a bit more about it here rails/webpacker#2387

@banukutlu banukutlu requested a review from cdmo May 18, 2020 13:46
@banukutlu
Copy link
Contributor Author

banukutlu commented May 18, 2020

@cdmo finally I was able to get the travis build to pass by installing an newer version of node. This is ready for review now.

Copy link
Contributor

@cdmo cdmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prolly want to look at updating webpacker as well in the not to distant future too 👍

@cdmo cdmo merged commit be4bd96 into master May 18, 2020
@cdmo cdmo deleted the webpacker-upgrade branch May 18, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants