Remove default from rules (#2662)

https://webpack.js.org/configuration/module/#ruleparser Default is requireEnsure: false, // disable require.ensure
rails · Aug 16, 2020 · c71dc65 · c71dc65
1 parent 82a1332
commit c71dc65
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/package/environments/__tests__/base.js b/package/environments/__tests__/base.js
@@ -31,37 +31,41 @@ describe('Environment', () => {
 
     test('should return multi file entry points', () => {
       const config = environment.toWebpackConfig()
-      expect(config.entry.multi_entry.sort()).toEqual(
-          [
-            resolve('app', 'javascript', 'packs', 'multi_entry.css'),
-            resolve('app', 'javascript', 'packs', 'multi_entry.js')
-          ]
-      )
+      expect(config.entry.multi_entry.sort()).toEqual([
+        resolve('app', 'javascript', 'packs', 'multi_entry.css'),
+        resolve('app', 'javascript', 'packs', 'multi_entry.js')
+      ])
     })
 
     test('should return output', () => {
       const config = environment.toWebpackConfig()
       expect(config.output.filename).toEqual('js/[name]-[contenthash].js')
-      expect(config.output.chunkFilename).toEqual('js/[name]-[contenthash].chunk.js')
+      expect(config.output.chunkFilename).toEqual(
+        'js/[name]-[contenthash].chunk.js'
+      )
     })
 
     test('should return default loader rules for each file in config/loaders', () => {
       const config = environment.toWebpackConfig()
       const defaultRules = Object.keys(rules)
       const configRules = config.module.rules
 
-      expect(defaultRules.length).toEqual(7)
-      expect(configRules.length).toEqual(8)
+      expect(defaultRules.length).toEqual(6)
+      expect(configRules.length).toEqual(6)
     })
 
     test('should return cache path for nodeModules rule', () => {
-      const nodeModulesLoader = rules.nodeModules.use.find(rule => rule.loader === 'babel-loader')
+      const nodeModulesLoader = rules.nodeModules.use.find(
+        (rule) => rule.loader === 'babel-loader'
+      )
 
       expect(nodeModulesLoader.options.cacheDirectory).toBeTruthy()
     })
 
     test('should return cache path for babel-loader rule', () => {
-      const babelLoader = rules.babel.use.find(rule => rule.loader === 'babel-loader')
+      const babelLoader = rules.babel.use.find(
+        (rule) => rule.loader === 'babel-loader'
+      )
 
       expect(babelLoader.options.cacheDirectory).toBeTruthy()
     })

diff --git a/package/environments/base.js b/package/environments/base.js
@@ -163,7 +163,7 @@ module.exports = class Base {
 
       module: {
         strictExportPresence: true,
-        rules: [{ parser: { requireEnsure: false } }, ...this.loaders.values()]
+        rules: this.loaders.values()
       },
 
       plugins: this.plugins.values(),