Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle tailwindcss:watch[always] #262

Merged
merged 1 commit into from Apr 20, 2023

Conversation

GoodForOneFare
Copy link
Contributor

Passes -w always along to tailwindcss, which keeps the watch going even if stdin closes (tailwindlabs/tailwindcss#9966).

@rafaelfranca
Copy link
Member

Any reason why this can't be the default of tailwindcss:watch?

@GoodForOneFare
Copy link
Contributor Author

@rafaelfranca the default behaviour is IMO better. In most environments, the default mode cleans up its own orphaned processes. The tailwind developers added --watch always with reluctance, and I think it's only useful for niche environments where developers don't have control of their Docker config.

@rafaelfranca rafaelfranca merged commit 3e95f8f into rails:main Apr 20, 2023
20 checks passed
@GoodForOneFare GoodForOneFare deleted the watch-always branch April 21, 2023 01:49
@flavorjones
Copy link
Member

@GoodForOneFare I could use your help to understand what we should add to the "troubleshooting" section to help users understand when to use this feature. What will people see if they need to set this?

flavorjones added a commit that referenced this pull request Apr 21, 2023
@flavorjones
Copy link
Member

See e665b09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants