Add a note about using asset pipeline assets #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dixpac
reviewed
Feb 13, 2022
README.md
Outdated
| @@ -90,6 +90,27 @@ A fix for this has been proposed upstream at https://github.com/tailwindlabs/tai | |||
| apk add build-base gcompat | |||
| ``` | |||
|
|
|||
| ### Using asset-pipeline assets | |||
|
|
|||
| To use assets from the asset pipeline one would normally use `asset-url`. This doesn't work with Tailwind, as the CSS is not processed with sass. Instead use `url(image.svg)`, [since Sprockets v3.3.0](https://github.com/rails/sprockets-rails/pull/476) the URL will automatically be rewritten. In Tailwind this looks like this: | |||
There was a problem hiding this comment.
the URL will automatically be rewritten for me as a reader this is a bit too abstract, can we expand a bit on this so I don't have to open PR link to understand what rewritten means.
|
We should just assert how it works. No need to confuse it with what used to be true in the past. |
Clarify how it works so readers don't have to open the Sprockets PR. Also remove any mention of how it used to work, this should be an evergreen README comment.
|
I have rewritten the paragraph that explains how it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't aware of how to use assets with this gem. I can image more people will have this issue when they're used to
asset-url. So to help them add a note to the README.See #137