Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure asset source is utf-8 encoded #794

Closed
wants to merge 1 commit into from

Conversation

AyoubEssrifi
Copy link

This is a modest fix for the issue mentioned here #498.

@brenogazzola
Copy link
Contributor

Hey @AyoubEssrifi would mind explaining why you gave up on this? Propshaft has the same problem and I was considering forcing UTF-8 encoding there too, so I'm wondering you figured out something that would mean this approach is going to cause problems.

@AyoubEssrifi
Copy link
Author

@brenogazzola For some reason, when i deleted the extension part of some Coffeescript or Coffe/ERB files in the main application.js:

Bad example:
//= require example.js.coffee.erb

Working example:
//= require example

that gets called on the manifest.js, Sprockets was able to correctly handle encoding and didn't have any issues with it. This was not mentioned anywhere on the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants