Fix .sprockets-manifest and gzip reproducibility issues #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantm
force-pushed
the
r13y
branch
5 times, most recently
from
4596a7d
to
116596a
Compare
When building Rails assets with Nix, I found they are almost completely reproducible save the manifest file, and the gzipped files. This commit fixes those issues. For more information about why it is good for a build to be reproducible see: https://reproducible-builds.org/ Here are the reproducibility issues and how they were fixed: 1. .sprckets-manifest contained the time when the assets were generated. Instead use timestamp 1. 2. gzip encoded the file mtime in the archive, which is not reproducible. Instead use timestamp 1. 3. .sprockets-manifest generating a random path for this file is not reproducible. Instead use the file's data to generate a digest.
|
I'm closing this in favor of separate PRs for each fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Rails assets with Nix, I found they are almost completely reproducible save the manifest file, and the gzipped files. This commit fixes those issues. For more information about why it is good for a build to be reproducible see:
https://reproducible-builds.org/
Here are the reproducibility issues and how they were fixed:
Fixes #707