optimize split_file_uri #570
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
ahorek
force-pushed
the
optimize_split_file_uri
branch
from
eaa590e
to
66b39ee
Compare
| @@ -47,14 +47,16 @@ def test_split_file_uri | |||
| parts = split_file_uri("file:///usr/local/var/github/app/assets/javascripts/application.js") | |||
| assert_equal ['file', nil, '/usr/local/var/github/app/assets/javascripts/application.js', nil], parts | |||
|
|
|||
| parts = split_file_uri("file:///C:/Documents%20and%20Settings/davris/FileSchemeURIs.doc") | |||
| assert_equal ['file', nil, 'C:/Documents and Settings/davris/FileSchemeURIs.doc', nil], parts | |||
| if DOSISH | |||
There was a problem hiding this comment.
Why we need this conditional now?
There was a problem hiding this comment.
file:///C:/ is not a valid uri on linux
There was a problem hiding this comment.
Right, but this test was running and passing on linux, so why add the conditional now?
There was a problem hiding this comment.
the previous version always stripped C: from path
path.gsub!(/^\/([a-zA-Z]:)/, '\1'.freeze)
now we can eliminate this line, because these paths shouldn't exist on nix systems.
windows
file:///C:/Documents
vs nix
file:///usr/local
I need to add guards for these tests. On windows it's still stripped but in a more efficient way
path = path[1..-1]
this gsub is more complicated than it needs to be
related #503