master perf proper #510
master perf proper #510
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -67,7 +67,8 @@ def self.default_logger | |||
| # cache - A compatible backend cache store instance. | |||
| def initialize(cache = nil, logger = self.class.default_logger) | |||
| @cache_wrapper = get_cache_wrapper(cache) | |||
| @fetch_cache = Cache::MemoryStore.new(1024) | |||
| fetch_cache_size = cache.respond_to?(:max_size) ? cache.max_size / 1000 : 1024 | |||
There was a problem hiding this comment.
Why divide by 1000? Why not just have them input the number that they want?
Also dividing an integer by an integer will give us a bad value 1/1000 # => 0
There was a problem hiding this comment.
i have new patches, need to cleanup and a new pull request will follow, maybe next week.
|
i close this, i created a opal-webpack-loader instead |
#503