New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.x perf #506
Closed
Closed
3.x perf #506
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
28d9de1
perf: regex only on windows
janbiedermann bc5167e
perf: provide self.fast_compress, saves object inst and method_call
janbiedermann 7258906
match tests to regexp only on windows
janbiedermann 2ddd769
perf: to much work for nothing, no more
janbiedermann 6276753
case is faster then .call_ing on a hash
janbiedermann 54056d7
use fast_compress
janbiedermann 3c666b4
fix
janbiedermann 83db3e3
increase default cache
janbiedermann File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,11 +13,11 @@ def initialize(uri, env) | |
@root = env.root | ||
@env = env | ||
uri = uri.to_s | ||
if uri.include?("://".freeze) | ||
@scheme, _, @path = uri.partition("://".freeze) | ||
@scheme << "://".freeze | ||
if uri.include?('://'.freeze) | ||
@scheme, _, @path = uri.partition('://'.freeze) | ||
@scheme << '://'.freeze | ||
else | ||
@scheme = "".freeze | ||
@scheme = ''.freeze | ||
@path = uri | ||
end | ||
end | ||
|
@@ -35,6 +35,21 @@ def compress | |
scheme + compressed_path | ||
end | ||
|
||
def self.fast_compress(uri, root) | ||
if uri.include?('://'.freeze) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't need all the freeze calls. We're using the magic comment in the files: # frozen_string_literal: true There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh, right, missed that |
||
scheme, _, path = uri.partition('://'.freeze) | ||
scheme << '://'.freeze | ||
else | ||
scheme = ''.freeze | ||
path = uri | ||
end | ||
if compressed_path = PathUtils.split_subpath(root, path) | ||
scheme + compressed_path | ||
else | ||
scheme + path | ||
end | ||
end | ||
|
||
# Internal: Tells us if we are using an absolute path | ||
# | ||
# Nix* systems start with a `/` like /Users/schneems. | ||
|
@@ -66,7 +81,7 @@ def expand | |
else | ||
# We always want to return an absolute uri, | ||
# make sure the path starts with a slash. | ||
scheme + File.join("/".freeze, root, path) | ||
scheme + File.join('/'.freeze, root, path) | ||
end | ||
end | ||
end | ||
|
@@ -82,8 +97,8 @@ def expand | |
# Returns String | ||
def compressed_path | ||
# windows | ||
if !@root.start_with?("/".freeze) && path.start_with?("/".freeze) | ||
consistent_root = "/".freeze + @root | ||
if !@root.start_with?('/'.freeze) && path.start_with?('/'.freeze) | ||
consistent_root = '/'.freeze + @root | ||
else | ||
consistent_root = @root | ||
end | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're allocating an array everytime this if code is called. We can speed it up by using a pre-allocated constant
Gives us