Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: optimize split_file_uri #505

Closed
wants to merge 3 commits into from

Conversation

ahorek
Copy link
Contributor

@ahorek ahorek commented Oct 13, 2017

this gsub is more complicated than it needs to be

related #503

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@ahorek
Copy link
Contributor Author

ahorek commented Oct 13, 2017

I need to skip some tests, but file:///C:/ isn't valid on linux, right?

@ahorek
Copy link
Contributor Author

ahorek commented Oct 13, 2017

windows ruby 2.4.2: 3x - 10x
linux ruby 2.4.2: 9x - 28x
windows jruby 9.1.13.0: 1.5x - 2x
linux jruby 9.1.13.0: 12x - 20x

@ahorek ahorek closed this Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants