Use a dedicated ActiveSupport::Deprecation #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennebarrie
force-pushed
the
add-deprecator
branch
from
0c9da83
to
9f18b4e
Compare
skipkayhil
reviewed
May 7, 2023
lib/sprockets/railtie.rb
Outdated
| @@ -125,6 +125,10 @@ def configure(&block) | |||
| Sprockets.register_postprocessor "application/javascript", ::Sprockets::Rails::SourcemappingUrlProcessor | |||
| end | |||
|
|
|||
| initializer :deprecator do |app| | |||
There was a problem hiding this comment.
Suggested change
| initializer :deprecator do |app| | |
| initializer "sprockets-rails.deprecator" do |app| |
While the other initializers here don't do this (and probably never will due to backwards incompatibility), I think any new initializers added should be namespaced so that they don't conflict with any other gems.
(Duplicate initializer names has been a problem before: rails/rails#43261 (comment))
There was a problem hiding this comment.
Hum there's already a namespace in the sense that all initializers are defined within a Railtie.
$ bin/rails initializers | grep deprecator
Sprockets::Railtie.deprecator
(Rails 7.0 app running with this branch)
It feels like the issue you're mentioning is more a bug/misfeature in Railtie::Initializable but OK.
I see all the other deprecators have a namespace in their initializer's name so that makes sense.
Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance. This defines one for the gem and uses it. It's also added to the application's set of deprecators, allowing it to be configured along all the other deprecators.
etiennebarrie
force-pushed
the
add-deprecator
branch
from
9f18b4e
to
d8495d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 will deprecate using the singleton ActiveSupport::Deprecation instance (rails/rails#47354). This defines one for the gem and uses it.
It's also added to the application's set of deprecators, allowing it to be configured along all the other deprecators.
cc @rafaelfranca