Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Move to GitHub actions and drop TravisCI.
Gemfile
has been update to point torails:main
becauserails:master
no longer existssuper()
inRack::Request::Env
rack/rack#1751ActionView::Base.new
, we now pass in{}, null
for the locals and controller respectively.media="screen"
which has now been removed see Remove legacy default media=screen from stylesheet_link_tag rails#41215 is needed for the tests to pass for Rails versions < 7. Rather than instantiation a rails app and setting the configRails.application.config.action_view.stylesheet_media_default=true
, this seems like the easier fix.Anything else
I have split into 2 commits, 1 for the build (which is currently failing on travis ci) and the other for the test fixes, but let me know if you want me to squash into 1 commit.
The GitHub actions are not being run here, but you can see them all green here https://github.com/hahmed/sprockets-rails/actions/runs/952618642 -- not sure why I can see the actions workflow on my fork but not upstream, but @byroot mentioned if we merged this PR we would prob see the actions here too.
Should we consider updating the target ruby version in a follow up PR, perhaps ruby 2.7?