Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused development_dependency sass and uglifier #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

junaruga
Copy link
Contributor

sass and uglifier are set in sprockets-rails.gemspec as development dependency.
And those look used in test/test_railtie.rb test_compressors
However it is actually not used in the test, and it works without these gems.
So, I think we can remove these development dependencies.

Remove sass and uglifier lines from the gemspec file.

$ vi sprockets-rails.gemspec
$ ruby -v
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]

$ bundle install --path vendor/bundle

$ bundle list
Gems included by the bundle:
  * actionpack (5.1.0.alpha 6e692e6)
  * actionview (5.1.0.alpha 6e692e6)
  * activesupport (5.1.0.alpha 6e692e6)
  * builder (3.2.2)
  * bundler (1.12.5)
  * concurrent-ruby (1.0.2)
  * erubis (2.7.0)
  * i18n (0.7.0)
  * loofah (2.0.3)
  * method_source (0.8.2)
  * mini_portile2 (2.1.0)
  * minitest (5.9.1)
  * nokogiri (1.6.8.1)
  * rack (2.0.1 1482870)
  * rack-test (0.6.3)
  * rails-dom-testing (2.0.1)
  * rails-html-sanitizer (1.0.3)
  * railties (5.1.0.alpha 6e692e6)
  * rake (11.3.0)
  * sprockets (3.7.0 99b3eb2)
  * sprockets-rails (3.2.0)
  * thor (0.19.1)
  * thread_safe (0.3.5)
  * tzinfo (1.2.2)

$ bundle exec rake test
...
152 runs, 752 assertions, 0 failures, 0 errors, 0 skips 

Run only target test just in case.

$ bundle exec ruby -Ilib test/test_railtie.rb --name test_compressors
...
1 runs, 3 assertions, 0 failures, 0 errors, 0 skips

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants