Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog tweak for lazy routes [ci skip] #51796

Merged
merged 1 commit into from May 13, 2024

Conversation

Earlopain
Copy link
Contributor

Small followup to #51614. I believe this is important to call out since my first thought was along the lines of "hey, I don't really want it to do that".

@rails-bot rails-bot bot added the railties label May 12, 2024
@Earlopain
Copy link
Contributor Author

Does [ci skip] no longer work or did I do it wrong somehow?

@skipkayhil
Copy link
Member

skipkayhil commented May 13, 2024

Does [ci skip] no longer work or did I do it wrong somehow?

Correct, it was disabled since many lints were moved into the Buildkite pipeline, meaning we always want the pipeline to run now

Earlopain added a commit to Earlopain/rails that referenced this pull request May 13, 2024
@rafaelfranca rafaelfranca changed the base branch from main to 7-2-stable May 13, 2024 16:56
@rafaelfranca rafaelfranca merged commit 04dfe88 into rails:7-2-stable May 13, 2024
4 checks passed
@Earlopain Earlopain deleted the lazy-routes-changelog branch May 13, 2024 16:58
@zzak
Copy link
Member

zzak commented May 13, 2024

So the build is still run on Buildkite with ci skip (and variations) in the PR title and head commit message, but you will notice that the main Rails pipeline was skipped: https://buildkite.com/rails/rails/builds/107044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants