Add active_record.postgresql_adapter_decode_dates config
#51763
Merged
+103
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JoeDupuis
force-pushed
the
postgresql-adapter-decode-dates-config
branch
from
1ea165b
to
b8c3f24
Compare
ghiculescu
reviewed
May 8, 2024
ghiculescu
reviewed
May 8, 2024
...ib/rails/generators/rails/app/templates/config/initializers/new_framework_defaults_7_2.rb.tt
Outdated
Show resolved
Hide resolved
ghiculescu
reviewed
May 8, 2024
ghiculescu
reviewed
May 8, 2024
activerecord/test/cases/adapters/postgresql/postgresql_adapter_test.rb
Outdated
Show resolved
Hide resolved
ghiculescu
reviewed
May 8, 2024
activerecord/lib/active_record/connection_adapters/postgresql_adapter.rb
Show resolved
Hide resolved
JoeDupuis
force-pushed
the
postgresql-adapter-decode-dates-config
branch
2 times, most recently
from
fddc0b8
to
b4fcbe7
Compare
JoeDupuis
force-pushed
the
postgresql-adapter-decode-dates-config
branch
from
b4fcbe7
to
dafe0fc
Compare
JoeDupuis
commented
May 9, 2024
JoeDupuis
force-pushed
the
postgresql-adapter-decode-dates-config
branch
2 times, most recently
from
b2bfd24
to
153fbaf
Compare
byroot
force-pushed
the
postgresql-adapter-decode-dates-config
branch
from
153fbaf
to
401c1d3
Compare
JoeDupuis
force-pushed
the
postgresql-adapter-decode-dates-config
branch
from
401c1d3
to
c40b8b7
Compare
|
@byroot I rebased to fix the failing tests. I pushed a attempt at a fix for the flake: #51783 |
JoeDupuis
force-pushed
the
postgresql-adapter-decode-dates-config
branch
from
c40b8b7
to
95f9822
Compare
to toggle automatic decoding of dates column with the PostgresqlAdapter. PR rails#51483 is a breaking change and should have been gated behind a config.
rafaelfranca
force-pushed
the
postgresql-adapter-decode-dates-config
branch
from
95f9822
to
478874a
Compare
rafaelfranca
added a commit
that referenced
this pull request
May 15, 2024
…tes-config Add `active_record.postgresql_adapter_decode_dates` config
|
If you're using AR outside of Rails, this now stops decoding dates entirely, right? |
|
@zzak Yup, without Rails, it would default to the old behavior before the breaking change was introduced. I am hoping to add a deprecation warning at some point and remove the old behavior entirely. Adding the deprecation warning in this PR turned out more complex than anticipated. Any concern? |
|
Nope, sorry I am still catching up. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
active_record.postgresql_adapter_decode_datesconfigto toggle automatic decoding of dates column with the PostgresqlAdapter.
PR #51483 is a breaking change and should have been gated behind a config.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]