Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip]Add period to end of comment sentences for consistency #51677

Merged
merged 2 commits into from Apr 29, 2024

Conversation

SeesawEffectt
Copy link
Contributor

This Pull Request has been created because there were two files with a few comments that did not end in periods but should have to fit the style of the rest of the comments in said files, which did all end with periods.

Detail

This Pull Request changes comments in /railties/lib/rails/generators/rails/app/templates/config/environments, in both
/test.rb.tt and /development.rb.tt. No code-related functionality is modified.

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why.
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

Two comments didn't have periods while the rest of them did in this file.
The rest of the comments ended in periods but this comment didn't, making it inconsistent with the rest of the file.
@rails-bot rails-bot bot added the railties label Apr 28, 2024
@carlosantoniodasilva carlosantoniodasilva merged commit cc7f0b0 into rails:main Apr 29, 2024
2 checks passed
fractaledmind pushed a commit to fractaledmind/rails that referenced this pull request May 13, 2024
…cy (rails#51677)

Add periods to comments in development.rb.tt and test.rb.tt for consistency.
[ci skip]

Co-authored-by: Carlos Antonio da Silva <carlosantoniodasilva@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants