Support css background-image attributes with cid: on mail preview #51656
+9
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Mail preview support show inline attachments for
<img>
tag, but have not support forbackground-image
css attribute. But this is also valid way to use inline images in emails. More info: https://email2go.io/blog/how-to-use-background-images-in-email-templatesExample of usage in erb template:
without this fix:
with this fix:
Did not found tests for
InlinePreviewInterceptor
, so if I am missed add test cases, please point me where to add its